Add tests that ko can push to quay.io and Dockerhub #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #778 +/- ##
=======================================
Coverage 51.32% 51.32%
=======================================
Files 44 44
Lines 3330 3330
=======================================
Hits 1709 1709
Misses 1403 1403
Partials 218 218 Help us with your feedback. Take ten seconds to tell us how you rate us. |
jonjohnsonjr
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rely on long-lived credentials stored in GitHub repository secrets.
We should also investigate adding tests for ECR and GCR using OIDC credentials, probably reusing those used by go-containerregistry.