Add build.Limiter #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can limit the number of concurrent builds with -j (a la make). The default value for this is GOMAXPROCS, which seems reasonable.
imjasonh
reviewed
Sep 10, 2019
| // Build implements Interface | ||
| func (l *Limiter) Build(ip string) (v1.Image, error) { | ||
| // TODO(jonjohnsonjr): Build should take a context.Context. | ||
| if err := l.semaphore.Acquire(context.TODO(), 1); err != nil { |
There was a problem hiding this comment.
Is there any reason not to use sync.WaitGroup? I'm unfamiliar with the semaphore package, but it seems like it's main benefit is weightedness, which we're not taking advantage of here.
There was a problem hiding this comment.
WaitGroup is similar, but AFAICT there is no way to bound the maximum number of the counter, whereas NewWeighted takes a maximum weight.
imjasonh
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can limit the number of concurrent builds with -j (a la make).
The default value for this is GOMAXPROCS, which seems reasonable.
cc @JungukCho