Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ko.local and kind.local detection to include sub-repos #796

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

imjasonh
Copy link
Member

Prior to this, if I set KO_DOCKER_REPO=kind.local/foo/bar, this logic would attempt to publish to a remote registry named kind.local. Same with ko.local.

@codecov-commenter
Copy link

Codecov Report

Merging #796 (3c96e97) into main (2c58e4a) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #796   +/-   ##
=======================================
  Coverage   51.45%   51.45%           
=======================================
  Files          44       44           
  Lines        3339     3339           
=======================================
  Hits         1718     1718           
  Misses       1401     1401           
  Partials      220      220           
Impacted Files Coverage Δ
pkg/commands/resolver.go 34.02% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh imjasonh added this to the 0.12 milestone Aug 22, 2022
@imjasonh imjasonh merged commit 568da16 into ko-build:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants