Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --tag and --tag-only with nop publisher #797

Merged
merged 5 commits into from
Aug 24, 2022

Conversation

imjasonh
Copy link
Member

Supercedes #689

cc @adambkaplan

With this change, if you use --push=false and -t, the output ref includes the tag. If you include --tag-only the resulting output ref will only include the tag, and not the digest. I'm not sure what purpose that would be useful for, but it's consistent with pushing cases at least.

@imjasonh imjasonh requested a review from mattmoor August 22, 2022 15:35
@imjasonh imjasonh added this to the 0.12 milestone Aug 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #797 (d325733) into main (2c58e4a) will decrease coverage by 0.05%.
The diff coverage is 47.05%.

@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
- Coverage   51.45%   51.40%   -0.06%     
==========================================
  Files          44       44              
  Lines        3339     3354      +15     
==========================================
+ Hits         1718     1724       +6     
- Misses       1401     1408       +7     
- Partials      220      222       +2     
Impacted Files Coverage Δ
pkg/commands/resolver.go 34.32% <47.05%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh imjasonh merged commit f9775dc into ko-build:main Aug 24, 2022
@adambkaplan
Copy link

@imjasonh thanks for getting this over the finish line!

@imjasonh
Copy link
Member Author

@imjasonh thanks for getting this over the finish line!

Thanks for noticing the issue and for your very helpful PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants