feat: adding support for using multiple keychain for sending sbom results to a different repository #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
reviewed
Sep 12, 2022
developer-guy
force-pushed
the
feature/819
branch
4 times, most recently
from
e6d83b9
to
90691ad
Compare
developer-guy
changed the title
Codecov Report
@@ Coverage Diff @@
## main #821 +/- ##
==========================================
- Coverage 51.37% 51.32% -0.05%
==========================================
Files 44 44
Lines 3354 3361 +7
==========================================
+ Hits 1723 1725 +2
- Misses 1408 1413 +5
Partials 223 223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
2 tasks
imjasonh
reviewed
Sep 12, 2022
developer-guy
force-pushed
the
feature/819
branch
5 times, most recently
from
b5a430b
to
d87917b
Compare
developer-guy
force-pushed
the
feature/819
branch
2 times, most recently
from
012b1b3
to
b4558dc
Compare
imjasonh
reviewed
Sep 12, 2022
developer-guy
force-pushed
the
feature/819
branch
from
b4558dc
to
1bc2951
Compare
developer-guy
force-pushed
the
feature/819
branch
from
1bc2951
to
8763180
Compare
imjasonh
reviewed
Sep 18, 2022
|
Thanks for the work @developer-guy and the review @imjasonh ! Would like to get the support in! |
developer-guy
force-pushed
the
feature/819
branch
2 times, most recently
from
d66d1de
to
8cbefe1
Compare
|
I think we are in good shape for this PR 🕺🏻🥳 |
imjasonh
reviewed
Sep 20, 2022
developer-guy
force-pushed
the
feature/819
branch
from
8cbefe1
to
c372eb3
Compare
developer-guy
force-pushed
the
feature/819
branch
from
c372eb3
to
8462b2c
Compare
imjasonh
reviewed
Sep 21, 2022
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
developer-guy
force-pushed
the
feature/819
branch
from
8462b2c
to
d0af639
Compare
imjasonh
approved these changes
Sep 21, 2022
|
I'd love to see a test for this new behavior, but I've already taken long enough reviewing this so I won't block on it. Thanks for adding this! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
Fixes #819