Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for using multiple keychain for sending sbom results to a different repository #821

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

developer-guy
Copy link
Collaborator

@developer-guy developer-guy commented Sep 12, 2022

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Fixes #819

pkg/publish/options.go Show resolved Hide resolved
pkg/publish/default.go Outdated Show resolved Hide resolved
@developer-guy developer-guy force-pushed the feature/819 branch 4 times, most recently from e6d83b9 to 90691ad Compare September 12, 2022 19:36
@developer-guy developer-guy changed the title feat: adding support for AUX_REPOSITORY to send sboms feat: adding support for using multiple keychain for sending sbom results to a different repository Sep 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #821 (8ca7d87) into main (bb84aa3) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

❗ Current head 8ca7d87 differs from pull request most recent head 90691ad. Consider uploading reports for the commit 90691ad to get more accurate results

@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   51.37%   51.32%   -0.05%     
==========================================
  Files          44       44              
  Lines        3354     3361       +7     
==========================================
+ Hits         1723     1725       +2     
- Misses       1408     1413       +5     
  Partials      223      223              
Impacted Files Coverage Δ
pkg/commands/resolver.go 34.32% <0.00%> (ø)
pkg/publish/options.go 20.83% <0.00%> (-1.56%) ⬇️
pkg/publish/default.go 55.24% <100.00%> (+0.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good, just a few small things.

pkg/publish/default.go Outdated Show resolved Hide resolved
pkg/commands/resolver.go Outdated Show resolved Hide resolved
pkg/publish/options.go Outdated Show resolved Hide resolved
pkg/publish/default.go Outdated Show resolved Hide resolved
@realshuting
Copy link

Thanks for the work @developer-guy and the review @imjasonh ! Would like to get the support in!

@developer-guy
Copy link
Collaborator Author

developer-guy commented Sep 20, 2022

I think we are in good shape for this PR 🕺🏻🥳

pkg/publish/default.go Outdated Show resolved Hide resolved
pkg/publish/default.go Outdated Show resolved Hide resolved
pkg/publish/default.go Outdated Show resolved Hide resolved
pkg/publish/options.go Outdated Show resolved Hide resolved
pkg/publish/options.go Outdated Show resolved Hide resolved
pkg/publish/options.go Show resolved Hide resolved
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@imjasonh
Copy link
Member

I'd love to see a test for this new behavior, but I've already taken long enough reviewing this so I won't block on it.

Thanks for adding this! 👍

@imjasonh imjasonh merged commit e93dbee into ko-build:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

let putting SBOMs in a different repository
5 participants