Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix link to Installation page in Getting Started #846

Merged
merged 1 commit into from
Oct 12, 2022
Merged

doc: fix link to Installation page in Getting Started #846

merged 1 commit into from
Oct 12, 2022

Conversation

antoineco
Copy link
Contributor

Fixes the 404 error when clicking the link to the Installation page located at the top of the Getting Started page.

@imjasonh
Copy link
Member

Thanks for sending this fix!

This looks right to me, but now I'm worried we have other similar links scattered around.

I wonder if we should configure use_directory_urls: false so the URLs look like https://ko.build/get_started.html instead, and ./install would work again (maybe only with .html?)

I don't think this comment needs to block the PR (thank you again!) I'm just ruminating about how we want URLs to look and work.

I should also run a link checker on the site to see if anything else is broken. 💀

@imjasonh imjasonh merged commit 1c69d9c into ko-build:main Oct 12, 2022
@antoineco
Copy link
Contributor Author

That could be an option, potentially it could make relative links more intuitive but I have to admit I have only scratched the surface with mkdocs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants