-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish an tagged image on release #868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
reviewed
Oct 25, 2022
Fixes ko-build#847 Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
publish-image-on-release
branch
from
October 25, 2022 14:43
e23aebe
to
40b1da9
Compare
imjasonh
reviewed
Oct 25, 2022
Thanks @imjasonh Co-authored-by: Jason Hall <jason@chainguard.dev>
imjasonh
previously approved these changes
Oct 25, 2022
imjasonh
reviewed
Oct 25, 2022
No need for GITHUB_TOKEN, setup-ko handles it already. Co-authored-by: Jason Hall <jason@chainguard.dev>
imjasonh
reviewed
Oct 26, 2022
Co-authored-by: Jason Hall <jason@chainguard.dev>
imjasonh
approved these changes
Oct 30, 2022
mattmoor
approved these changes
Oct 31, 2022
imjasonh
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #847
Signed-off-by: Vincent Demeester vincent@sbr.pm