Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix KO_CONFIG_PATH pointing to a file #923

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Jan 10, 2023

Fixes #919

@imjasonh imjasonh requested a review from jonjohnsonjr January 10, 2023 18:16
jonjohnsonjr
jonjohnsonjr previously approved these changes Jan 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #923 (dc910f9) into main (7bf3626) will decrease coverage by 0.08%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
- Coverage   51.30%   51.21%   -0.09%     
==========================================
  Files          44       44              
  Lines        3417     3419       +2     
==========================================
- Hits         1753     1751       -2     
- Misses       1435     1439       +4     
  Partials      229      229              
Impacted Files Coverage Δ
pkg/commands/options/build.go 68.29% <90.00%> (-2.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works 👼🏼 🤗

@imjasonh imjasonh merged commit 453bf80 into ko-build:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KO_CONFIG_PATH pointing to a file doesn't work
4 participants