-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add KO_GO_PATH env var #930
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
4871951
to
e310747
Compare
Codecov Report
@@ Coverage Diff @@
## main #930 +/- ##
==========================================
+ Coverage 51.21% 52.42% +1.20%
==========================================
Files 44 43 -1
Lines 3419 3325 -94
==========================================
- Hits 1751 1743 -8
+ Misses 1439 1353 -86
Partials 229 229
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sorry for complicating this PR by including |
Ah, let me wait until your PR is in and then rebase. |
Ready after rebase @imjasonh |
Closes: ko-build#926 Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Makes
go
version used to build image binaries configurable viaKO_GO_PATH
. Optional, defaults togo
resolved from$PATH
.Closes: #926
Signed-off-by: Michael Gasch 15986659+embano1@users.noreply.github.com