Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add KO_GO_PATH env var #930

Merged
merged 2 commits into from
Jan 19, 2023
Merged

feat: Add KO_GO_PATH env var #930

merged 2 commits into from
Jan 19, 2023

Conversation

embano1
Copy link
Contributor

@embano1 embano1 commented Jan 13, 2023

Makes go version used to build image binaries configurable via KO_GO_PATH. Optional, defaults to go resolved from $PATH.

Closes: #926
Signed-off-by: Michael Gasch 15986659+embano1@users.noreply.github.com

@google-cla
Copy link

google-cla bot commented Jan 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

pkg/commands/deps.go Outdated Show resolved Hide resolved
pkg/build/gobuild.go Outdated Show resolved Hide resolved
pkg/commands/deps.go Outdated Show resolved Hide resolved
@embano1 embano1 force-pushed the issue-926 branch 2 times, most recently from 4871951 to e310747 Compare January 18, 2023 10:25
imjasonh
imjasonh previously approved these changes Jan 18, 2023
@imjasonh imjasonh changed the title feat: Add KO_GO_BIN env var feat: Add KO_GO_PATH env var Jan 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #930 (e310747) into main (72e2752) will increase coverage by 1.20%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
+ Coverage   51.21%   52.42%   +1.20%     
==========================================
  Files          44       43       -1     
  Lines        3419     3325      -94     
==========================================
- Hits         1751     1743       -8     
+ Misses       1439     1353      -86     
  Partials      229      229              
Impacted Files Coverage Δ
pkg/commands/commands.go 61.53% <ø> (-2.75%) ⬇️
pkg/build/gobuild.go 57.07% <72.72%> (+0.10%) ⬆️
pkg/build/cache.go 41.66% <100.00%> (+0.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh
Copy link
Member

Sorry for complicating this PR by including ko deps' removal in it. I've split that out into #937

@embano1
Copy link
Contributor Author

embano1 commented Jan 18, 2023

Ah, let me wait until your PR is in and then rebase.

@embano1
Copy link
Contributor Author

embano1 commented Jan 19, 2023

Ready after rebase @imjasonh

Closes: ko-build#926
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
imjasonh
imjasonh previously approved these changes Jan 19, 2023
docs/configuration.md Outdated Show resolved Hide resolved
@imjasonh imjasonh merged commit f6025f9 into ko-build:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make go and kubectl version configurable
3 participants