Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add ECR presubmit testing. #934

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Feature: Add ECR presubmit testing. #934

merged 1 commit into from
Jan 16, 2023

Conversation

mattmoor
Copy link
Collaborator

🎁 This leverages OIDC federation to enable presubmit testing against ECR.

/kind feature

@mattmoor mattmoor changed the title Feature: Add ECR presubmit testing. [WIP] Feature: Add ECR presubmit testing. Jan 16, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #934 (e0eb352) into main (76f46cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #934   +/-   ##
=======================================
  Coverage   51.21%   51.21%           
=======================================
  Files          44       44           
  Lines        3419     3419           
=======================================
  Hits         1751     1751           
  Misses       1439     1439           
  Partials      229      229           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

developer-guy
developer-guy previously approved these changes Jan 16, 2023
Copy link
Collaborator

@developer-guy developer-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, LGTM

🎁 This leverages OIDC federation to enable presubmit testing against ECR.

/kind feature
@mattmoor mattmoor changed the title [WIP] Feature: Add ECR presubmit testing. Feature: Add ECR presubmit testing. Jan 16, 2023
@mattmoor mattmoor merged commit 72e2752 into main Jan 16, 2023
@mattmoor mattmoor deleted the ecr-tests branch January 16, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants