Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release workflow #977

Merged
merged 2 commits into from
Mar 14, 2023
Merged

fix release workflow #977

merged 2 commits into from
Mar 14, 2023

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Mar 10, 2023

This breaks because the release doesn't have a built ko binary yet.

This only runs publish after the goreleaser job has finished and binaries are available.

I think we could also just remember not to check "this is the latest release" when cutting a new release, but I will never remember to do that.

For this release I'm just going to retry the failed job after goreleaser finishes.

@imjasonh imjasonh requested a review from jonjohnsonjr March 10, 2023 17:12
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #977 (4d713c0) into main (8e075ae) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #977   +/-   ##
=======================================
  Coverage   52.50%   52.50%           
=======================================
  Files          43       43           
  Lines        3331     3331           
=======================================
  Hits         1749     1749           
  Misses       1353     1353           
  Partials      229      229           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh imjasonh enabled auto-merge (squash) March 10, 2023 17:22
Copy link
Collaborator

@developer-guy developer-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@imjasonh imjasonh merged commit 0e4dbdd into ko-build:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants