Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use attestation-name output #980

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

ianlewis
Copy link
Contributor

Fixes #978

Uses the attestation-name output from generator_generic_slsa3.yml to get the artifact name to download.

Also removes the compile-generator input as slsa-framework/slsa-github-generator#1163 was fixed.

Fixes ko-build#978

Uses the `attestation-name` output from `generator_generic_slsa3.yml` to get the artifact name to download.

Also removes the `compile-generator` input as slsa-framework/slsa-github-generator#1163 was fixed.

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #980 (5e6b5d7) into main (8e075ae) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #980   +/-   ##
=======================================
  Coverage   52.50%   52.50%           
=======================================
  Files          43       43           
  Lines        3331     3331           
=======================================
  Hits         1749     1749           
  Misses       1353     1353           
  Partials      229      229           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@imjasonh imjasonh merged commit 2860fcf into ko-build:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.13.0 release failed provenance validation
4 participants