Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go120 #984

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Upgrade to go120 #984

merged 4 commits into from
Mar 14, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 14, 2023

  • upgrade to use go1.20
  • bump go module to require minimum go1.19

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
imjasonh
imjasonh previously approved these changes Mar 14, 2023
@imjasonh imjasonh enabled auto-merge (squash) March 14, 2023 12:31
@cpanato
Copy link
Member Author

cpanato commented Mar 14, 2023

will fix the gofmt

Signed-off-by: cpanato <ctadeu@gmail.com>
auto-merge was automatically disabled March 14, 2023 12:37

Head branch was pushed to by a user without write access

@cpanato cpanato requested a review from imjasonh March 14, 2023 12:42
Signed-off-by: cpanato <ctadeu@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #984 (4af3a15) into main (2860fcf) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #984   +/-   ##
=======================================
  Coverage   52.50%   52.50%           
=======================================
  Files          43       43           
  Lines        3331     3331           
=======================================
  Hits         1749     1749           
  Misses       1353     1353           
  Partials      229      229           
Impacted Files Coverage Δ
pkg/build/config.go 0.00% <ø> (ø)
pkg/commands/commands.go 61.53% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh imjasonh enabled auto-merge (squash) March 14, 2023 14:35
@imjasonh imjasonh merged commit 4cde944 into ko-build:main Mar 14, 2023
@cpanato cpanato deleted the upgrade-to-go120 branch March 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants