Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify variable name: root_dir_or_paths -> root_dir (#136) #149

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

lovit
Copy link
Member

@lovit lovit commented Nov 1, 2020

Pull Request

Korpora에 기여해 주셔서 감사합니다.

해당 Pull Request를 제출하기 전에 아래 사항이 완료되었는지 확인 부탁드립니다:

  • 작성한 코드가 어떤 에러나 경고 없이 실행이 되나요?
  • 작성한 코드에 대한 테스트 코드를 만드셨나요? (경로 : Korpora/test)
  • 기존 코드 역시 에러 없이 수행이 되겠죠?

1. 해당 PR은 어떤 내용인가요?

다른 코퍼스들과 통일성을 유지하기 위하여 root_dir_or_paths 라는 변수를 root_dir 로 수정합니다.

2. PR과 관련된 이슈가 있나요?

#136 , #121 (comment)

@lovit lovit requested a review from ratsgo November 1, 2020 06:53
Copy link
Member

@ratsgo ratsgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

검토 마쳤습니다! 고생 많으셨어요

@lovit lovit merged commit 590e044 into dev Nov 2, 2020
@lovit lovit deleted the dev-fix-aihub branch November 11, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants