Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy and translate korsts.md #163

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Copy and translate korsts.md #163

merged 1 commit into from
Nov 15, 2020

Conversation

warnikchow
Copy link
Contributor

1. 해당 PR은 어떤 내용인가요?

korsts.md 를 번역하였습니다

2. PR과 관련된 이슈가 있나요?

Copy와 translate의 commit을 따로 하는 과정이 생략되었는데, 이는 다음 commit시에 다시 반영토록 하겠습니다!

@warnikchow warnikchow requested review from lovit and hank110 November 10, 2020 12:50

You can download the corpus without executing Python console.
The command is as below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 커멘트에서 언급한 것처럼 @warnikchow @hank110 두 분이 결정해 주시면 좋을 듯 합니다.

Copy link
Member

@lovit lovit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내용 확인하였습니다. 이전 커밋들과 충돌이 없음도 확인하였습니다. 수고하셨습니다.

@lovit
Copy link
Member

lovit commented Nov 11, 2020

Copy와 translate의 commit을 따로 하는 과정이 생략되었는데, 이는 다음 commit시에 다시 반영토록 하겠습니다!

리뷰 시에 생략된 내용이 없는지 확인할 수 있다는 점에서 좋은 전략이라 생각합니다. (참고: @hank110 )
감사합니다.

@lovit lovit mentioned this pull request Nov 15, 2020
@lovit
Copy link
Member

lovit commented Nov 15, 2020

in terminal 에 관련된 커멘트는 여기 에 추가 기록해두었습니다. 그 외에는 이상이 없기에 제가 merge 하겠습니다.

@lovit lovit merged commit f69260c into pages-en Nov 15, 2020
@lovit lovit deleted the pages-en-korsts branch November 15, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants