Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify variable name in Korean Docs (#121) #167

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Unify variable name in Korean Docs (#121) #167

merged 1 commit into from
Nov 15, 2020

Conversation

ratsgo
Copy link
Member

@ratsgo ratsgo commented Nov 15, 2020

Pull Request

Korpora에 기여해 주셔서 감사합니다.

해당 Pull Request를 제출하기 전에 아래 사항이 완료되었는지 확인 부탁드립니다:

  • 작성한 코드가 어떤 에러나 경고 없이 실행이 되나요?
  • 작성한 코드에 대한 테스트 코드를 만드셨나요? (경로 : Korpora/test)
  • 기존 코드 역시 에러 없이 수행이 되겠죠?

1. 해당 PR은 어떤 내용인가요?

한국어 설명 문서에서 root_dir_or_paths라고 표현된 변수명을 root_dir로 통일하는 PR입니다.
pages 브랜치에 머지합니다.

2. PR과 관련된 이슈가 있나요?

#121

@ratsgo ratsgo requested a review from lovit November 15, 2020 11:49
Copy link
Member

@lovit lovit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모두의 말뭉치의 7개, AI Hub 의 1개 파일의 수정 내용을 확인하였습니다. 수고하셨습니다.

@ratsgo ratsgo merged commit 43a8fd7 into pages Nov 15, 2020
@ratsgo ratsgo deleted the fix-ko-pages branch November 15, 2020 13:03
This was referenced Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants