Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update README.md to better explain the default for the origin parameter #91

Merged
merged 1 commit into from
Dec 12, 2023
Merged

docs: Update README.md to better explain the default for the origin parameter #91

merged 1 commit into from
Dec 12, 2023

Conversation

julienw
Copy link
Contributor

@julienw julienw commented Dec 12, 2023 •
edited
Loading

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@julienw julienw changed the title docs: Update README.md to better explain the default for the origin p… docs: Update README.md to better explain the default for the origin parameter Dec 12, 2023
julienw referenced this pull request Dec 12, 2023
@fengmk2
Merge pull request from GHSA-qxrj-hx23-xp82
f31dac9 
This is a security update for the Same Origin Policy (SOP),
and also a BREAKING CHANGE.

closes GHSA-qxrj-hx23-xp82
fengmk2
fengmk2 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 merged commit 18a43f0 into koajs:master Dec 12, 2023
8 checks passed
@fengmk2
Copy link
Member

fengmk2 commented Dec 12, 2023

@julienw Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienw @fengmk2