fix: handle upper case protocol like HTTP or HTTPS (#1805)

Co-authored-by: fengmk2 <suqian.yf@antgroup.com>
koajs · Mar 21, 2024 · d5a681b · d5a681b
1 parent 549455d
commit d5a681b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/__tests__/response/redirect.js b/__tests__/response/redirect.js
@@ -21,6 +21,13 @@ describe('ctx.redirect(url)', () => {
     assert.strictEqual(ctx.status, 302);
   });
 
+  it('should formatting url before redirect', () => {
+    const ctx = context();
+    ctx.redirect('HTTP://google.com\\@apple.coM/okoK');
+    assert.strictEqual(ctx.response.header.location, 'http://google.com/@apple.coM/okoK');
+    assert.strictEqual(ctx.status, 302);
+  })
+
   it('should auto fix not encode url', done => {
     const app = new Koa();
 

diff --git a/lib/response.js b/lib/response.js
@@ -261,7 +261,7 @@ module.exports = {
   redirect(url, alt) {
     // location
     if ('back' === url) url = this.ctx.get('Referrer') || alt || '/';
-    if (url.startsWith('https://') || url.startsWith('http://')) {
+    if (/^https?:\/\//i.test(url)) {
       // formatting url again avoid security escapes
       url = new URL(url).toString();
     }