Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ESM transpiled CommonJS play nice for TS folks, fix #1513 #1518

Merged
merged 3 commits into from
Jan 4, 2021

Conversation

miwnwski
Copy link
Member

@miwnwski miwnwski commented Jan 4, 2021

This is a "fix" I guess to allow TS typings to actually work - according to some other people that actually use TS.

I'm going to need confirmation on both its application, and that this doesn't break anything for Koa v2.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #1518 (2fbed91) into master (b4398f5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1518   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          487       489    +2     
  Branches       136       136           
=========================================
+ Hits           487       489    +2     
Impacted Files Coverage Δ
lib/application.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4398f5...2fbed91. Read the comment docs.

@dead-horse dead-horse merged commit b5472f4 into koajs:master Jan 4, 2021
@miwnwski miwnwski deleted the export-default branch January 4, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants