Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release next branch to npm #33

Closed
ratson opened this issue Dec 5, 2015 · 5 comments
Closed

Release next branch to npm #33

ratson opened this issue Dec 5, 2015 · 5 comments

Comments

@ratson
Copy link

ratson commented Dec 5, 2015

I tried it and it looks good, is there anything blocking it to release on npm?

@haoxins
Copy link
Member

haoxins commented Dec 6, 2015

@jonathanong May I publish koa-mount@2 (Of course as dist-tag next)

@tejasmanohar
Copy link
Member

+1 from me. Looks fine, assuming next dist-tag.

@haoxins
Copy link
Member

haoxins commented Jan 9, 2016

Since existing next branch has never been published, and according to koajs/koa#625, just close this for now.
I'm going to delete the existing promise based next branch.

@haoxins haoxins closed this as completed Jan 9, 2016
@tejasmanohar
Copy link
Member

imo-

  • if there's already a working next branch and koa convert doesn't work for mount, i'd just publish this to npm
  • if koa convert does work for mount, ignore this. no point of converting to promise-based middleware

@haoxins haoxins mentioned this issue Jan 21, 2016
@nevercast
Copy link

Why was the branch decidedly deleted? Was it clutter?

Edit: Ahh I see it utilized promises instead of just async/await. Unfortunately that didn't affect me because Babel replaced async/await with Promises anyway, so they were one and the same. Implementation was compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants