Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koa@2 #32

Closed
wants to merge 4 commits into from
Closed

Koa@2 #32

wants to merge 4 commits into from

Conversation

haoxins
Copy link
Member

@haoxins haoxins commented Nov 19, 2015

Maybe it's better to write with babel + async ?

@tejasmanohar
Copy link
Member

I use async/await for pretty much all Koa 2 middleware that I write outside of this org, but it seems we don't wanna use Babel in KoaJS official stuff yet... unless we vote on it again and decide otherwise. Basically, I suggest whatever we do, we're consistent on this decision amongst all official middleware.

Other than that, +1 on this PR :)

// cc @jonathanong

@haoxins
Copy link
Member Author

haoxins commented Nov 20, 2015

Just as discussed in koajs/etag#16, this looks like callback style 😢 .
Hold on, util there are some conclusions in koajs/koa#533

@tejasmanohar
Copy link
Member

Agreed @coderhaoxin, gonna wait on this... - I'm also not so content with how the new Promise-based middleware is looking here without async/await. Hopefully, we can resolve the policy for using async/await other middleware in the org rather than just Koa core in that issue :)

@tejasmanohar tejasmanohar mentioned this pull request Nov 20, 2015
@haoxins
Copy link
Member Author

haoxins commented Nov 20, 2015

we can resolve the policy for using async/await other middleware in the org rather than just Koa core in that issue

@tejasmanohar +1

@tejasmanohar
Copy link
Member

@coderhaoxin +1 / vote on the other thread :)

@haoxins haoxins closed this Nov 24, 2015
@haoxins haoxins deleted the koa@2 branch November 24, 2015 06:16
@haoxins
Copy link
Member Author

haoxins commented Nov 24, 2015

according to koajs/koa#603, land on https://github.com/koajs/mount/tree/next

haoxins referenced this pull request Nov 24, 2015
@niftylettuce
Copy link

what happened to @next support?

@haoxins
Copy link
Member Author

haoxins commented Jan 21, 2016

#33

@haoxins
Copy link
Member Author

haoxins commented Jan 21, 2016

#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants