Skip to content

Commit

Permalink
chore: drop node 12 from tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@titanism
titanism committed Jul 4, 2022
1 parent d0c6d8b commit fdf7117
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ jobs:
os:
- ubuntu-latest
node_version:
- 12
- 14
- 16
- 18
Expand Down

3 comments on commit fdf7117

@trentm
Copy link

@trentm trentm commented on fdf7117 Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Is node v12 still supported for @koa/router v11 then (according to the "engines" entry in package.json)? Thanks.

@titanism
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @trentm - just the tests were removed for Node 12, but it still works for Node 12.

@trentm
Copy link

@trentm trentm commented on fdf7117 Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Please sign in to comment.