Fix ctx.routerPath causes routes to fail path matches issue #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like the tests are failing right now @dsmackie, can you take a double look? |
|
I stuff it up. Closing! |
|
What? |
|
@niftylettuce I realised that I did not update the tests so closed this. I also do not think I am approaching this in the right way. Updating I think it would be best to do the check further up when Can you check out the attached issue and comment if this is even an issue or maybe intended? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue discussed at #101.
If a
ctx.pathcontains parameters then do not updatectx.routerPathto equallayer.path. Instead, keep the originalctx.pathso future matches can occur.All tests PASS.