Allow router.redirect() to accept external destinations #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @apancutt thank you for your contribution. Please can you write some unit tests for this ? |
|
Tests were added, @dominicegginton. Do you have an ETA for the next version? |
|
one sec |
|
v10.0.0 released to npm https://github.com/koajs/router/releases/tag/v10.0.0 |
|
Was this a breaking change? Why was this a major version bump? |
|
@domnantas This PR implements a breaking change so required a major version bump. |
|
I'm trying to understand how exactly this is a breaking change. How should I update my application so it wouldn't break after updating Koa router? I'm having trouble understanding how https://github.com/koajs/router/pull/110/files#diff-f2e6763bf8bb6c8d2158eccc82da1212d91d40dd73a3e110c1c4c3a3382fc5a6R535 could be a breaking change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
router.redirect()only accepts route names or absolute URLs. External URLs (e.g. https://www.example.com) will be treated as a route name resulting in a route-not-found error.