Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support symbols as route names #143

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Conversation

noinkling
Copy link
Contributor

As outlined in #142

Just some minimal changes and tests. I haven't touched the documentation because I don't know if you want to support this "officially" or not.

@etroynov
Copy link
Contributor

@noinkling in what cases it can be useful?

@noinkling
Copy link
Contributor Author

@etroynov It's described in the linked issue (#142)

@etroynov
Copy link
Contributor

@noinkling could you resolve the conflict?

@noinkling
Copy link
Contributor Author

could you resolve the conflict?

Done.

@titanism
Copy link
Contributor

titanism commented Jul 4, 2022

We have just published @koajs/router v11.0.0 which resolves this issue. This is mirrored to koa-router as well.

https://github.com/koajs/router/releases/tag/v11.0.0

This project is maintained by Forward Email and Lad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants