Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve for .prefix() #151

Merged
merged 1 commit into from
Jun 25, 2022
Merged

doc: improve for .prefix() #151

merged 1 commit into from
Jun 25, 2022

Conversation

etroynov
Copy link
Contributor

Improve doc for .prefix() method.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@etroynov
Copy link
Contributor Author

@niftylettuce can you check my PR? Thx.

p.s sry for the direct message by reviewers for PR not available :(

@etroynov
Copy link
Contributor Author

@3imed-jaberi @jmealo @dominicegginton can you review?

3imed-jaberi
3imed-jaberi approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@titanism titanism merged commit 4fb50ac into koajs:master Jun 25, 2022
@etroynov
Copy link
Contributor Author

@3imed-jaberi thx a lot!

@titanism
Copy link
Contributor

titanism commented Jul 4, 2022

We have just published @koajs/router v11.0.0 which resolves this issue. This is mirrored to koa-router as well.

https://github.com/koajs/router/releases/tag/v11.0.0

This project is maintained by Forward Email and Lad.

@WontonSam WontonSam mentioned this pull request Jul 18, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etroynov @titanism @3imed-jaberi