Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vip, vi and vi_model S3 methods for workflow objects #99

Closed
wants to merge 5 commits into from

Conversation

Athospd
Copy link

@Athospd Athospd commented Apr 17, 2020

vip, vi and vi_model S3 methods for workflow objects

ref: https://tidymodels.github.io/workflows/

@bgreenwell
Copy link
Member

Thanks for the PR @Athospd, any chance you can add some tests?

Example here: https://github.com/koalaverse/vip/blob/master/inst/tinytest/test_pkg_parsnip.R

@Athospd
Copy link
Author

Athospd commented Apr 21, 2020

Of course! I looked for the tests in the wrong folder =P (there is a empty 'tests' folder btw).

@topepo
Copy link
Contributor

topepo commented Apr 16, 2021

Can I suggest that adding a function to check to see if the workflow has been fit (right before passing the fit object in)?

check_wflow_fittted <- function(x) {
  if (is.null(x$fit$fit)) {
    stop("Please fit the workflow.")
  }
  invisible(x)
}

@bgreenwell
Copy link
Member

Updated and addressed in #128.

@bgreenwell bgreenwell closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants