DeadZoneRegressor
support for "constant" effect
#588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR solves #587 by adding support for
effect="constant"
.Additionally, as discussed in the issue, it removes the need of autograd by implementing derivative by hand (😂) and by using scipy.optimize.minimize for optimization.
This leads to a few potential breaking changing in the API as the following argument are no longer needed:
and the following attributes are no longer available:
Type of change
Checklist:
If you feel your PR is ready for a review, ping @koaning or @MBrouns.