Make umap-learn dependency optional
#592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Oct 26, 2023
| @@ -28,7 +31,7 @@ def __init__(self, package_name: str, version: str = None): | |||
| + f"`python -m pip install scikit-lego[{extra_name}]` or " | |||
| + "`python -m pip install scikit-lego[all]`. " | |||
| + "For more information, check the 'Dependency installs' section of the installation docs at " | |||
| + "https://scikit-lego.readthedocs.io/en/latest/install.html" | |||
| + "https://scikit-lego.netlify.app/install" | |||
There was a problem hiding this comment.
Unrelated but was pointing to the wrong page
There was a problem hiding this comment.
Once we move everything unto mkdocs ... I think we'll also port away from netlify and move it all to Github Pages. That deployment is super straightforward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes
umap-learndependency optional in the same fashion of how it is done withcvxpy.I will update documentation in the open PR accordingly if and when merged.
Checklist:
If you feel your PR is ready for a review, ping @koaning or @MBrouns.