[DOCS] Fix relative paths #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
added
documentation
FBruzzesi
commented
Jan 4, 2024
| @@ -1,16 +1,16 @@ | |||
| [](https://github.com/{github_id}/{repository}/workflows/{workflow_name}/badge.svg) | |||
There was a problem hiding this comment.
Not sure if Build status is still relevant, I couldn't find a passing status though.
The adjusted link leads to "no status"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the deployed docs in github pages, all relative links are broken. I would imagine that the issue is similar to what happened in #602 .
This PR tries to patch that.
Most annoying fact is that locally both strategies work.
Edit: Adding screenshot as example:
Clicking the link at https://koaning.github.io/scikit-lego/#usage to open the user guide
maps to https://koaning.github.io/user-guide/datasets (which is 404) instead of https://koaning.github.io/scikit-lego/user-guide/datasets/