-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with scikit-learn 1.6rc1 #720
Conversation
So current tests are all passing, which is definitly a good sign that we did not break anything. I tested with scikit-learn1.6rc1 locally (python3.10, ubuntu) and successfully |
Whoa. So many changes. I guess the best check is to merge it now and to see if something breaks in the future, but nothing jumped out of the ordinary. |
Ah, I did the merge and now stuff seems breaking again 😓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing state to reflect some tests break.
This is ... odd. The tests locally in codespaces run just fine but they break in CI. |
I will try to take a better look this weekend.. Should we pin scikit-learn version until we fix this? |
Ah, 1.6 is no longer a release candidate I think. Let's delay version pinning unless folks start to submit issues. It could be that we are worrying about details that aren't a huge worry for folks. |
Yes, 1.6 is now definitly released 🙃 |
Description
Diff is simpler than expected:
__sklearn_tags__
to all the classes that changes the default tagssklego.common
that perform validation either viavalidate_data
(scikit>=1.6) orcheck_X_y
andcheck_array
(scikit < 1.6).There are some checks which are not fully compatible, and one that might be buggy in this RC:
check_sample_weight_equivalence
seems to fail on every of our estimators that supportsample_weight
- it might be worth reporting upstream, but I could not pin the issueCloses #719