Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jaeger: results not refreshing when changing tracked service #142

Closed
marwonline opened this issue Sep 9, 2021 · 1 comment · Fixed by #143
Closed

Jaeger: results not refreshing when changing tracked service #142

marwonline opened this issue Sep 9, 2021 · 1 comment · Fixed by #143
Labels
bug Something isn't working

Comments

@marwonline
Copy link
Contributor

marwonline commented Sep 9, 2021 •
edited
Loading

Describe the bug

The Jaeger traces are not refreshed when changing the service.

To Reproduce

  1. Go to http://kobs.demo/jaeger
  2. Select any service
  3. Click search button
  4. Change the service
  5. Click search button
  6. The URL changes but the results are not updated. The API call still uses the first service. Reloading the page loads the desired traces.

Expected behavior

URL changes and triggers change of the traces in the results view.

Screenshots

Additional context
@marwonline marwonline added the bug Something isn't working label Sep 9, 2021
ricoberger added a commit that referenced this issue Sep 9, 2021
@ricoberger
Fix bug where Jaeger results were not refreshed
81ccb13 
In #130 we changed the options for the Jaeger plugin to allow multiple
queries. For that we set the initial selected query to the first query
from the "queries" property. This caused a bug, were the results were
not refreshed after a user changed the service, operation, etc. on the
Jaeger page, because we didn't updated the selected query. The selected
query is now always updated when the queries property is changed and
when it only contains one query, which is always the case for the page
implementation of the Jaeger plugin.

Fixes #142.
@ricoberger ricoberger mentioned this issue Sep 9, 2021
Merged
3 tasks
@ricoberger
Copy link
Member

Oh indeed. Thanks for reporting 🙂.

Why is it not surprising to me that you are the first to find and report a bug 😅

ricoberger added a commit that referenced this issue Sep 9, 2021
@ricoberger
Fix bug where Jaeger results were not refreshed (#143)
c34827e 
In #130 we changed the options for the Jaeger plugin to allow multiple
queries. For that we set the initial selected query to the first query
from the "queries" property. This caused a bug, were the results were
not refreshed after a user changed the service, operation, etc. on the
Jaeger page, because we didn't updated the selected query. The selected
query is now always updated when the queries property is changed and
when it only contains one query, which is always the case for the page
implementation of the Jaeger plugin.

Fixes #142.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug where Jaeger results were not refreshed kobsio/kobs
2 participants
@ricoberger @marwonline