Fix usage of memo and resource table for CRDs #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the usage of "memo" in the Dashboard component, where we forgot some important properties. This also fixes a problem with CRDs in the resources table. When the JSONPath for a shown column returned undefined and the column was of type date it showed NaN in the table. Now we are returning an empty string when the returned value from the JSONPath is undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the usage of "memo" in the Dashboard component, where
we forgot some important properties.
This also fixes a problem with CRDs in the resources table. When the
JSONPath for a shown column returned undefined and the column was of
type date it showed NaN in the table. Now we are returning an empty
string when the returned value from the JSONPath is undefined.