Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of traces in the Jaeger plugin #129

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

ricoberger
Copy link
Member

We had the problem, that in some cases the UI of the Jaeger plugin was
broken, when the trace wasn't as expected. To handle all these special
cases we decided to use some functions from the jaegertracing/jaeger-ui
repository, because the know what they do. Now all cases which can be
handled by the Jaeger UI should also work within kobs.

We also improved they way how we are rendering the list of spans for a
trace. in former versions of kobs, the UI crashed when a trace contained
to much spans. Now we are using react-virtuoso to render these large
lists of spans, which improves the performance quite a lot. We tested
this with a trace with 13500 spans. The current solution for rendering
the spans isn't perfect, because we had to set a fixed sice for the
container. In the future we want to use "useWindowScroll" property of
the package, but at the moment we are seeing a bug with react-virtuoso
as it is also described in the react-virtualized project (#1671).

We had the problem, that in some cases the UI of the Jaeger plugin was
broken, when the trace wasn't as expected. To handle all these special
cases we decided to use some functions from the jaegertracing/jaeger-ui
repository, because the know what they do. Now all cases which can be
handled by the Jaeger UI should also work within kobs.

We also improved they way how we are rendering the list of spans for a
trace. in former versions of kobs, the UI crashed when a trace contained
to much spans. Now we are using react-virtuoso to render these large
lists of spans, which improves the performance quite a lot. We tested
this with a trace with 13500 spans. The current solution for rendering
the spans isn't perfect, because we had to set a fixed sice for the
container. In the future we want to use "useWindowScroll" property of
the package, but at the moment we are seeing a bug with react-virtuoso
as it is also described in the react-virtualized project (#1671).
@ricoberger ricoberger merged commit 4e8ca99 into main Sep 2, 2021
@ricoberger ricoberger deleted the fix-and-rework-jaeger-plugin branch September 2, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant