Fix handling of traces in the Jaeger plugin #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the problem, that in some cases the UI of the Jaeger plugin was
broken, when the trace wasn't as expected. To handle all these special
cases we decided to use some functions from the jaegertracing/jaeger-ui
repository, because the know what they do. Now all cases which can be
handled by the Jaeger UI should also work within kobs.
We also improved they way how we are rendering the list of spans for a
trace. in former versions of kobs, the UI crashed when a trace contained
to much spans. Now we are using react-virtuoso to render these large
lists of spans, which improves the performance quite a lot. We tested
this with a trace with 13500 spans. The current solution for rendering
the spans isn't perfect, because we had to set a fixed sice for the
container. In the future we want to use "useWindowScroll" property of
the package, but at the moment we are seeing a bug with react-virtuoso
as it is also described in the react-virtualized project (#1671).