Improve query performance for ClickHouse #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queries to get logs from ClickHouse over a large time range should now be faster. For this we are only returning a maximum of round about 10000 documents from ClickHouse. For this we had to remove the stats enpoint which returned the overall document count and the buckets data and added it to the documents endpoint. With the help of the retrieved buckets we are modifying the start time of a query, so that large queries should be faster. More information about this new approach can be found in the code as inline comment. For example, queries to get all logs from the last 7 days, which took up to 3 minutes, are taking 10 seconds now. Note: We decided for the 10000 limit, because the default limit in Kibana is 500 and so it should be large enough. In the future we can also provide an option in the ClickHouse configuration or an additional field in the Options component to increase this limit.
ricoberger
added a commit
that referenced
this pull request
Sep 14, 2021
Instead of running the counts and buckets query before getting the logs from ClickHouse we are now just running the buckets query. The count query was removed, because we can also determine the count by building the sum of the count in each bucket. This should improve the query performance for some queries by up to 50%. In #133 we introduced an setting, where we limit the amount of documents, which are returned by the API. There we set a limit of 10000 documents. This setting can now be set by the user via the additional options. If the user doesn't provide this option we set a default limit of 1000.
3 tasks
ricoberger
added a commit
that referenced
this pull request
Sep 14, 2021
Instead of running the counts and buckets query before getting the logs from ClickHouse we are now just running the buckets query. The count query was removed, because we can also determine the count by building the sum of the count in each bucket. This should improve the query performance for some queries by up to 50%. In #133 we introduced an setting, where we limit the amount of documents, which are returned by the API. There we set a limit of 10000 documents. This setting can now be set by the user via the additional options. If the user doesn't provide this option we set a default limit of 1000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries to get logs from ClickHouse over a large time range should now
be faster. For this we are only returning a maximum of round about 10000
documents from ClickHouse. For this we had to remove the stats enpoint
which returned the overall document count and the buckets data and added
it to the documents endpoint. With the help of the retrieved buckets we
are modifying the start time of a query, so that large queries should be
faster. More information about this new approach can be found in the
code as inline comment.
For example, queries to get all logs from the last 7 days, which took up
to 3 minutes, are taking 10 seconds now.
Note: We decided for the 10000 limit, because the default limit in
Kibana is 500 and so it should be large enough. In the future we can
also provide an option in the ClickHouse configuration or an additional
field in the Options component to increase this limit.