Fix loading of Jaeger services #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user opened the Jaeger plugin page, where the "serivce" query parameter was already present in the URL, the list of services wasn't loaded from our gRPC API. To fix this issue, we added a new function "GetServices" and split the gRPC call for services and operations, so that they are now loaded independently. We also added a new "All Operations" options to the select box for the operations, so that it is possible to unselect an already selected operation via the new "All Operations" option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user opened the Jaeger plugin page, where the "serivce" query
parameter was already present in the URL, the list of services wasn't
loaded from our gRPC API.
To fix this issue, we added a new function "GetServices" and split the
gRPC call for services and operations, so that they are now loaded
independently.
We also added a new "All Operations" options to the select box for the
operations, so that it is possible to unselect an already selected
operation via the new "All Operations" option.