[istio] Change upstream cluster and path handling #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the handling of the upstream cluster and path field in the Istio access logs. We are now using the upstream cluster in the React UI instead of the authority. For that we also removed the authority from the grouping condition in the SQL query for Clickhouse. When getting the path from Clickhouse we are now ignoring the query string.
ricoberger
deleted the
istio-change-upstream-cluster-and-path-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the handling of the upstream cluster and path field
in the Istio access logs.
We are now using the upstream cluster in the React UI instead of the
authority. For that we also removed the authority from the grouping
condition in the SQL query for Clickhouse.
When getting the path from Clickhouse we are now ignoring the query
string.