Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags as filter in the Jaeger plugin #55

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Conversation

ricoberger
Copy link
Member

It is now possible to directly add a tag from a span as filter in the
Jaeger plugin. To do so, a user has to click on the tag and then he must
click on the "Filter" link. In the current logic all existing tags are
replaced by the selected tag.

We also adjusted the compare page, by directly using react-dropzone
instead of the FileUpload component from Patternfly. This allows us to
have a cleaner layout on the page.

It is now possible to directly add a tag from a span as filter in the
Jaeger plugin. To do so, a user has to click on the tag and then he must
click on the "Filter" link. In the current logic all existing tags are
replaced by the selected tag.

We also adjusted the compare page, by directly using react-dropzone
instead of the FileUpload component from Patternfly. This allows us to
have a cleaner layout on the page.
@ricoberger ricoberger merged commit 295b5b2 into main Apr 28, 2021
@ricoberger ricoberger deleted the allow-filtering-via-tags branch April 28, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant