Improve error handling #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the error handling in our Go API. To return an error we can now directly call errresponse.Render, which sets the passed in status and returns the message and error as an JSON object to the user. This error will now also be logged in our custom request log handler.
ricoberger
force-pushed
the
improve-api-error-handling
branch
from
738b0e5 to
4246329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the error handling in our Go API. To return an
error we can now directly call errresponse.Render, which sets the passed
in status and returns the message and error as an JSON object to the
user. This error will now also be logged in our custom request log
handler.