Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify annotation position for kotlin #1264

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Modify annotation position for kotlin #1264

merged 1 commit into from
Jul 10, 2023

Conversation

jxnu-liguobin
Copy link
Collaborator

Description

Related to #ISSUE_NUMBER

Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala
  • Maven plugin
  • Gradle plugin
  • SBT plugin

@jxnu-liguobin jxnu-liguobin linked an issue Jul 6, 2023 that may be closed by this pull request
Unable to generate Kotlin data classes with custom annotations applied on field(by default, it's applied on getter). #1263
Closed
kobylynskyi
kobylynskyi approved these changes Jul 10, 2023
View reviewed changes
Copy link
Owner

@kobylynskyi kobylynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kobylynskyi kobylynskyi merged commit 5345d84 into kobylynskyi:main Jul 10, 2023
@jxnu-liguobin jxnu-liguobin deleted the fix-kotlin-annot branch July 21, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobylynskyi kobylynskyi kobylynskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jxnu-liguobin @kobylynskyi