Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/i18n made it work with nuxt3 & vite #7045

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Conversation

stephenjason89
Copy link
Contributor

@stephenjason89 stephenjason89 commented Aug 30, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 7a2583d

This pull request enhances the internationalization feature of the app by adding a language switcher in the default layout, refactoring the i18n module configuration, and enabling markdown rendering in the translations. It affects the files layouts/default.vue, nuxt.config.js, and utils/config/i18n.ts.

🤖 Generated by Copilot at 7a2583d

We are the rebels of the code
We break the chains of the default mode
We switch the language with a form and $i18n
We load the files with a glob and a function

@stephenjason89 stephenjason89 requested a review from a team as a code owner August 30, 2023 10:51
@stephenjason89 stephenjason89 requested review from daiagi and Jarsen136 and removed request for a team August 30, 2023 10:51
@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit a4b9673
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/64ef257665f7be0008c4a815
😎 Deploy Preview https://deploy-preview-7045--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 30, 2023

AI-Generated Summary: This pull request includes three patches that fix and refactor the i18n configuration of a Nuxt.js project.

The first patch fixes issues with the i18n configuration. It adds a new .vscode/tasks.json file and modifies the default.vue file to add a language selection dropdown. The i18n configuration in the nuxt.config.js is updated to include fallbackLocale and loadLanguagesAsync is moved a bit upwards. In i18n.ts, MarkdownIt is imported instead of being commented out, and the loadLocaleMessages() function gets replaced with default values.

The second patch removes unnecessary codes, deleting the .vscode/tasks.json file and removing a set locale to 'es' command on mount in default.vue

In the last patch, webpack replace.context is replaced with vite import.glob in i18n.ts for loading the locale files. Corresponding locale files loading method is modified as well. In the nuxt.config.js file, the fallbackLocale is removed.

Overall, these changes aim to improve the i18n configuration, remove unnecessary codes, and replace feature for more efficient code.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 30, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 30, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad reviewpad bot added medium Pull request is medium and removed small Pull request is small labels Aug 30, 2023
@roiLeo roiLeo self-requested a review August 30, 2023 11:17
@roiLeo roiLeo merged commit 8d99003 into kodadot:nuxt Aug 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.58 USD/DOT ~ 10.917 $DOT
🧗 13rFRPVKjJzQXVC8ZqHZv5YMmwmk4MU7z4HeYk218hEMpQXH
🔗 0x281d67c837d25e49ca5dbb17a7d76715d5564c1fdaab3c070e1f279b73bb47c8

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants