Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing hexcolor with existing alpha value will not replace full hexstring in editor #38

Closed
Mooreel opened this issue May 6, 2020 · 4 comments
Assignees
Labels

Comments

@Mooreel
Copy link

Mooreel commented May 6, 2020

Describe the bug
In case of an existing 8 char hexcolor value in the editor containing the alpha value, changing the alpha value in the colorpicker leads to not fully replacing the hexstring in the editor but inserting it so that in the editor a 10 char invalid hexcolor code appears.

To Reproduce
Steps to reproduce the behavior:

  1. Have a 8 char hexcode containing a two char alpha value in the editor
  2. click on the color picker square
  3. change alpha value
  4. leave color picker

Expected behavior
Full hexstring in codemirror editor is replaced with string from color picker

Screenshots
Editor 8char hex value
image

color picker: change alpha value
image

now editor has a 10 char hex value
image

Desktop (please complete the following information):

  • Windows
  • Chrome version 81.0.4044.129 (Official Build) (64-bit)
@Mooreel Mooreel changed the title Alpha value in codemirror not considered, alpha value change leads to 10 char hexcode Changing hexcolor with existing alpha value will not replace full hexstring in editor May 6, 2020
@Mooreel
Copy link
Author

Mooreel commented May 23, 2020

Are issues in this repo looked at? If there is a pointer where this bug might come from I can try fixing it myself.

@easylogic
Copy link
Collaborator

hi @Mooreel
Sorry to see the issue too late. I'll check the relevant code and tell you again.

@easylogic easylogic added the bug label Jun 4, 2020
@easylogic easylogic self-assigned this Jun 4, 2020
@easylogic
Copy link
Collaborator

I fixed this issue.

you can use v1.9.70 .

please test it.

@Mooreel
Copy link
Author

Mooreel commented Jun 5, 2020

Thank you very much for the support @easylogic . That indeed fixed it.

@Mooreel Mooreel closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants