Improve LinkedList Array initliasier #958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Improves the Linked List initiliaser to not use append for each element.
When using append, it iterates through the whole LinkedList everytime an item is appended.
Init with 10k Items before:
Init with 10k Items after:
Only issue I found, is that the Test crashes with a Bad Access, when using 100k items. I stopped testing if that happens with the old implementation after 50k though, because it already took a couple of minutes to get to 50k and it gets slower, the more items are added. I used the implementation with > 1.000.000 items without problems though
I didn't change the arrayLiteral initialiser, because I don't see anyone, typing that many numbers :)