Cmake version depends on version 3.8 due to nlohmann/json

[phunkyfish]

Causes issues when building OSMC and for users on Ubuntu as build platform. Creating issue instead of proposed PR: #190

Upstream issue here: nlohmann/json#1498
Upstream PR which relaxes the dependency: nlohmann/json#1441

[phunkyfish]

@StormTrooper @samnazarko will track from here instead of proposed PR.

The upstream PR which relaxed the dependency was incorrect, there is a new one proposed.

[samnazarko]

Do we have some progress on this? Anything we can do to help on our side?

Edit: this is now fixed

S

[phunkyfish]

So now we just need a release of nlohmann/json.

I would advise creating an upstream issue stating what you need and why it’s important. If it’s not ready for the next major release they might do a minor release just including the fix you need.

No harm in asking.

[StormTrooper]

3.6.1 has been pushed out (CMake Issue actually fixed in 3.6.0)

[phunkyfish]

Can you try updating the zip version and SHA hash here:

pvr.vuplus/depends/common/nlohmann-json/nlohmann-json.txt

Line 1 in 97c67ae

nlohmann-json https://github.com/nlohmann/json/archive/v3.5.0.tar.gz

And here:

pvr.vuplus/depends/common/nlohmann-json/nlohmann-json.sha256

Line 1 in 97c67ae

e0b1fc6cc6ca05706cce99118a87aca5248bd9db3113e703023d23f044995c1d

to see if it solves your issues?

The checksum for 3.6.1 will be: 80c45b090e40bf3d7a7f2a6e9f36206d3ff710acfa8d8cc1f8c763bb3075e22e

In the meantime I will test using 3.6.1.

[StormTrooper]

Updating to 3.6.1 fixes the issue. Build completes successfully.

[phunkyfish]

Great, will include the update in the next PR