-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use C++11 features supported by CMake 3.1. #1441
Use C++11 features supported by CMake 3.1. #1441
Conversation
c562b11
to
4fd9b52
Compare
Had to update the PR, I didn't modify the benchmark |
Reopened as per discussion on #1440 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sorry, but I am quite busy right now, so I did not find the time to check at this repo lately :-/ |
Ok, I understand, we've prevented the issue from getting closed which is good enough for today 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks a lot!!! |
This implements the proposed workaround to get the target fetaures to work on CMake versions before 3.8. I've confirmed this works on CMake 3.5.1, which is shipped with Ubuntu 16.04.
This relates to the discussion in #1428. And replaces pending PR #1440.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.