added create_with_enter option that means a user can type a new value an... #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and press enter to get it added. our UX expert insisted on this
|
Thanks! My client just asked for create on enter this week. She was talking about keyboard accessibility at the time. I described how she could down-arrow, then enter. She thought just pressing enter was more intuitive. |
|
I just notice something in the interface that might support this change. I clicked on the Select field, then typed a couple of characters. The only choice in the list was the one I wanted, so I reflexively pressed Enter, and that item was selected. It feels like it would be natural to do the same thing for Add (enter when done) as when selecting (enter when done). |
| @@ -231,6 +232,10 @@ class AbstractChosen | |||
| this.results_search() | |||
| when 13 | |||
| evt.preventDefault() | |||
| searchText = this.get_search_text() | |||
| if @create_option and @create_with_enter and @results_showing and searchTe | |||
There was a problem hiding this comment.
there are characters chopped of the end of this line..
koenpunt
force-pushed
the
option_adding
branch
from
8e0f0c0
to
e3f8d9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...d press enter to get it added. our UX expert insisted on this
Maybe we can even default this to true?