eval-addons: relative modules should not be exposed to global

koishijs · Aug 26, 2020 · 8cd0ff8 · 8cd0ff8
1 parent 3bfc694
commit 8cd0ff8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/plugin-eval-addons/src/worker.ts b/packages/plugin-eval-addons/src/worker.ts
@@ -134,11 +134,12 @@ async function createModule(path: string) {
     module = modules[identifier] = new SourceTextModule(outputText, { context, identifier })
   }
 
-  logger.debug('creating module %c', module.identifier)
+  const type = module instanceof SyntheticModule ? 'synthetic' : 'source text'
+  logger.debug('creating %s module %c', type, module.identifier)
   await module.link(linker)
   await module.evaluate()
 
-  if (module instanceof SourceTextModule) {
+  if (!path.includes('/')) {
     internal.setGlobal(path, module.namespace)
   }
   return module