feat(cli): support service diagnostics

packages/cli/src/loader.ts

@@ -118,14 +118,28 @@ export class Loader {
     const plugin = this.resolvePlugin(name)
     if (!plugin) return
 
+    const names = Object.keys(this.cache).filter((name) => {
+      const plugin = this.resolvePlugin(name)
+      const state = this.app.registry.get(plugin)
+      return state?.using.every(key => this.app[key])
+    })
+
     const state = this.app.dispose(plugin)
     if (state) logger.info(`dispose plugin %c`, name)
+
+    for (const name of names) {
+      this.diagnose(name)
+    }
   }
 
   reloadPlugin(name: string) {
     const plugin = this.resolvePlugin(name)
     if (!plugin) return
 
+    if (this.app.isActive) {
+      this.app._tasks.flush().then(() => this.diagnose(name))
+    }
+
     const state = this.app.dispose(plugin)
     const config = this.config.plugins[name]
     logger.info(`%s plugin %c`, state ? 'reload' : 'apply', name)
@@ -144,4 +158,14 @@ export class Loader {
     }
     return app
   }
+
+  diagnose(name: string) {
+    const plugin = this.resolvePlugin(name)
+    const state = this.app.registry.get(plugin)
+    if (!state) return
+
+    let missing = state.using.filter(key => !this.app[key])
+    if (!missing.length) return
+    this.app.logger('diagnostic').warn('plugin %c is missing required service %c', name, missing.join(', '))
+  }
 }

packages/cli/src/worker.ts

@@ -21,4 +21,8 @@ addons.prepare(config)
 const app = loader.createApp()
 
 app.plugin(addons, app.options)
-app.start()
+app.start().then(() => {
+  for (const name in loader.cache) {
+    loader.diagnose(name)
+  }
+})

packages/core/src/app.ts

@@ -91,9 +91,10 @@ export class App extends Context {
     this.isActive = true
     logger.debug('started')
     for (const callback of this.getHooks('ready')) {
-      this._tasks.execute(callback)
+      this._tasks.queue(callback())
     }
-    await this._tasks.tillIdle()
+    delete this._hooks.ready
+    await this._tasks.flush()
   }
 
   async stop() {
@@ -285,14 +286,14 @@ export namespace App {
 class TaskQueue {
   #internal = new Set<Promise<void>>()
 
-  execute(callback: () => any) {
-    const task = Promise.resolve(callback())
+  queue(value: any) {
+    const task = Promise.resolve(value)
       .catch(err => logger.warn(err))
       .then(() => this.#internal.delete(task))
     this.#internal.add(task)
   }
 
-  async tillIdle() {
+  async flush() {
     while (this.#internal.size) {
       await Promise.all(Array.from(this.#internal))
     }

packages/core/src/context.ts

@@ -1,4 +1,4 @@
-import { Logger, makeArray, remove, Random, Promisify, Awaitable, Dict, MaybeArray, defineProperty } from '@koishijs/utils'
+import { Logger, makeArray, remove, sleep, Random, Promisify, Awaitable, Dict, MaybeArray, defineProperty } from '@koishijs/utils'
 import { Command } from './command'
 import { Session } from './session'
 import { User, Channel, Modules } from './database'
@@ -413,7 +413,7 @@ export class Context {
 
     // handle special events
     if (name === 'ready' && this.app.isActive) {
-      this.app._tasks.execute(listener)
+      this.app._tasks.queue(sleep(0).then(() => listener()))
       return () => false
     } else if (name === 'dispose') {
       this.state.disposables[method](listener)

plugins/frontend/console/src/index.ts

@@ -26,19 +26,11 @@ declare module 'koishi' {
   }
 }
 
-export abstract class DataSource<T = any> {
-  protected start(): Awaitable<void> {}
-  protected stop(): Awaitable<void> {}
+export abstract class DataSource<T = any> extends Service {
   protected abstract get(forced?: boolean): Promise<T>
 
   constructor(protected ctx: Context, protected name: keyof Sources) {
-    Context.service(`console.${name}`)
-    ctx.console.services[name] = this as never
-
-    sleep(0).then(() => {
-      ctx.on('ready', () => this.start())
-      ctx.on('dispose', () => this.stop())
-    })
+    super(ctx, `console.${name}`, true)
   }
 
   protected broadcast(type: string, value: any) {