Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teach: +authority setting #114

Merged
merged 5 commits into from
Oct 17, 2020
Merged

teach: +authority setting #114

merged 5 commits into from
Oct 17, 2020

Conversation

undefined-moe
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #114 into develop will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #114      +/-   ##
===========================================
- Coverage    92.86%   92.71%   -0.16%     
===========================================
  Files           56       56              
  Lines         8541     8567      +26     
  Branches      1827     1828       +1     
===========================================
+ Hits          7932     7943      +11     
- Misses         609      624      +15     
Impacted Files Coverage Δ
packages/plugin-teach/src/index.ts 91.97% <100.00%> (-8.03%) ⬇️
packages/plugin-teach/src/internal.ts 93.51% <100.00%> (ø)
packages/plugin-teach/src/plugins/context.ts 100.00% <100.00%> (ø)
packages/plugin-teach/src/plugins/writer.ts 100.00% <100.00%> (ø)
packages/plugin-teach/src/utils.ts 95.40% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43934f2...34d557c. Read the comment docs.

@undefined-moe undefined-moe requested a review from shigma October 17, 2020 14:39
@undefined-moe
Copy link
Member Author

LGTM

@shigma shigma merged commit 4fa3299 into develop Oct 17, 2020
@shigma shigma deleted the teach-authority-setting branch October 17, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants