Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add connection string support #119

Merged
merged 15 commits into from
Oct 23, 2020
Merged

add connection string support #119

merged 15 commits into from
Oct 23, 2020

Conversation

arily
Copy link
Contributor

@arily arily commented Oct 21, 2020

No description provided.

@arily arily mentioned this pull request Oct 21, 2020
Closed
undefined-moe
undefined-moe requested changes Oct 21, 2020
View reviewed changes
packages/plugin-mongo/src/database.ts Outdated Show resolved Hide resolved
packages/plugin-mongo/src/database.ts Show resolved Hide resolved
shigma
shigma reviewed Oct 21, 2020
View reviewed changes
packages/plugin-mongo/src/database.ts Outdated Show resolved Hide resolved
packages/plugin-mongo/src/database.ts Outdated Show resolved Hide resolved
packages/plugin-mongo/src/database.ts Outdated Show resolved Hide resolved
@arily arily requested review from shigma and undefined-moe October 21, 2020 05:39
undefined-moe
undefined-moe requested changes Oct 21, 2020
View reviewed changes
Copy link
Member

@undefined-moe undefined-moe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also see ci issues

packages/plugin-mongo/src/database.ts Outdated Show resolved Hide resolved
@arily
Copy link
Contributor Author

arily commented Oct 21, 2020

also see ci issues

03ee301 will this fix it ? (my first time writing ts)

@arily arily requested a review from undefined-moe October 21, 2020 05:53
@codecov
Copy link

codecov bot commented Oct 21, 2020 •
edited
Loading

Codecov Report

Merging #119 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #119   +/-   ##
========================================
  Coverage    92.86%   92.86%           
========================================
  Files           56       56           
  Lines         8541     8541           
  Branches      1827     1827           
========================================
  Hits          7932     7932           
  Misses         609      609

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d05d354...8256ac0. Read the comment docs.

@arily
Copy link
Contributor Author

arily commented Oct 21, 2020

finally works.

undefined-moe
undefined-moe requested changes Oct 21, 2020
View reviewed changes
packages/plugin-mongo/src/database.ts Outdated Show resolved Hide resolved
packages/plugin-mongo/src/database.ts Outdated Show resolved Hide resolved
@arily
Copy link
Contributor Author

arily commented Oct 21, 2020

fixed f05eecd

undefined-moe
undefined-moe approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@undefined-moe undefined-moe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@undefined-moe undefined-moe changed the base branch from master to develop October 22, 2020 04:15
@undefined-moe
Copy link
Member

PTAL @shigma

@shigma
Copy link
Member

shigma commented Oct 23, 2020

@arily I adjusted interface and typings to fix warning from typescript.

@shigma shigma merged commit 3e2c728 into koishijs:develop Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@undefined-moe undefined-moe undefined-moe approved these changes

@shigma shigma Awaiting requested review from shigma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arily @undefined-moe @shigma @Ari-Arimaniac